fix(sqllab): Bump duckdb-engine version to 0.9.5#26405
Merged
rusackas merged 3 commits intoapache:masterfrom Jan 4, 2024
Merged
fix(sqllab): Bump duckdb-engine version to 0.9.5#26405rusackas merged 3 commits intoapache:masterfrom
rusackas merged 3 commits intoapache:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #26405 +/- ##
==========================================
- Coverage 69.14% 69.14% -0.01%
==========================================
Files 1946 1946
Lines 75990 75990
Branches 8479 8479
==========================================
- Hits 52544 52543 -1
- Misses 21267 21268 +1
Partials 2179 2179
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
villebro
reviewed
Jan 4, 2024
Member
villebro
left a comment
villebro
left a comment
There was a problem hiding this comment.
LGTM, but wondering if we should add an upper bound? I know you maintain the driver, so you're the best person to say if this is a valid concern or not..
john-bodley
reviewed
Jan 4, 2024
john-bodley
reviewed
Jan 4, 2024
michael-s-molina
added
the
v3.1
michael-s-molina
pushed a commit
that referenced
this pull request
Jan 9, 2024
Co-authored-by: John Bodley <4567245+john-bodley@users.noreply.github.com> (cherry picked from commit bba1b14)
josedev-union
pushed a commit
to Ortege-xyz/studio
that referenced
this pull request
Jan 22, 2024
Co-authored-by: John Bodley <4567245+john-bodley@users.noreply.github.com> (cherry picked from commit bba1b14)
mistercrunch
added
🍒 3.1.0
mistercrunch
added
🍒 3.1.2
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
Co-authored-by: John Bodley <4567245+john-bodley@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Currently, when a user selects a DuckDB database, the schema dropdown shows multiple instances of
main. This was an issue in the SQLAlchemy driver and has been fixed on the latest version ofduckdb_engine.BEFORE/AFTER SCREENSHOTS
Before:
After:
TESTING INSTRUCTIONS
db_name.schema_nameitems instead of manymainschema duplicatesADDITIONAL INFORMATION